Disallow to assign instance/class variable outside method dynamically #4950

makenowjust · 2017-09-11T02:39:56Z

This code can be compiled currently:

class Foo
  if true
    @foo = [] of Int32
  end
end

p Foo.new

but it is crashed at run time.

$ crystal run foo.cr
Invalid memory access (signal 11) at address 0x4

This fix prevents it.

@foo

This code can be compiled currently, but it is crashed at run time. class Foo if true @foo = [] of Int32 end end This fix prevents it.

makenowjust · 2017-09-11T03:31:27Z

Sorry my fix is not perfect. I close this and will open a new pull request when fixed correctly.

Disallow to assign instance/class variable outside method dynamically

f671a77

This code can be compiled currently, but it is crashed at run time. class Foo if true @foo = [] of Int32 end end This fix prevents it.

makenowjust closed this Sep 11, 2017

straight-shoota mentioned this pull request Sep 11, 2017

Disallow to assign instance variabls inside nested expressions #4951

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow to assign instance/class variable outside method dynamically #4950

Disallow to assign instance/class variable outside method dynamically #4950

makenowjust commented Sep 11, 2017

makenowjust commented Sep 11, 2017

Disallow to assign instance/class variable outside method dynamically #4950

Disallow to assign instance/class variable outside method dynamically #4950

Conversation

makenowjust commented Sep 11, 2017

makenowjust commented Sep 11, 2017