Update kubes to 1.7.0 #28575
Closed
Update kubes to 1.7.0 #28575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fresheyeball, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @moretea and @copumpkin to be potential reviewers. |
Mic92
reviewed
Aug 25, 2017
| @@ -40,6 +40,11 @@ stdenv.mkDerivation rec { | |||
| patchShebangs ./hack | |||
| ''; | |||
|
|
|||
| preBuild = '' | |||
| echo "verion:" | |||
There was a problem hiding this comment.
this should be probably removed again.
|
FYI. The k8s service also needs changes in order for that to work with a newer version. See #25426 |
|
ping @offlinehacker @matejc |
|
@Fresheyeball have you got a plan to upgrade the kubernetes service? If yes, then I suggest adding WIP tag here on github and some plan of attack, otherwise this should not be merged. |
|
I'm closing this in favour of #25426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Need access to breaking changes from the Kubernetes api, present in the new version.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)