Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texworks: init at 0.6.2 #29545

Merged
merged 1 commit into from Sep 21, 2017
Merged

texworks: init at 0.6.2 #29545

merged 1 commit into from Sep 21, 2017

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

vyp
vyp reviewed Sep 18, 2017
View reviewed changes
pkgs/applications/editors/texworks/default.nix Outdated
++ lib.optional withPython "-DWITH_PYTHON=ON";

meta = with stdenv.lib; {
description = "simple TeX front-end program inspired by TeXShop";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First letter of description should be capital https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected that

@dotlambda
Copy link
Member Author

Before you merge this, I'd like to know what the policy is regarding the platforms meta attribute. The build process on macOS seems to be the same as on Linux, but I have no system to test this on.
Would it still be okay to set meta.platforms to platforms.unix?

@Mic92
Copy link
Member

Mic92 commented Sep 19, 2017

I would say it is better to set it to linux first and wait for somebody to test it on macos. It might not even build for some reason due different dependencies.

@dotlambda
Copy link
Member Author

Okay, you can merge it now

@Mic92 Mic92 merged commit a3ed686 into NixOS:master Sep 21, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

Thanks!

@dotlambda dotlambda deleted the texworks branch January 17, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyp vyp vyp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @Mic92 @vyp