tshark: init at version 2.4.0 #29557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. So you want to say that when you build |
|
Please split in two commits, one for the build improvement and another for adding tshark alias. |
as an alias to wireshark-cli
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am used to the name "tshark" for the cli usage of wireshark. I was able to find out "wireshark-cli" but tshark is the true name.
Also when I install wireshark-cli, I don't want to recompile Qt + wireshark Qt UI but just the cli binary.
Things done
alias
tsharktowireshark-cliwhen using
wireshark-cli, build only the cli component (aka "tshark") and not the Qt interfaceTested using sandboxing (nix.useSandbox on NixOS, or option
build-use-sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.