Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: Add back leading '-' in cross derivation name suffix #29547

Merged
merged 1 commit into from Sep 18, 2017
Merged

stdenv: Add back leading '-' in cross derivation name suffix #29547

merged 1 commit into from Sep 18, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 18, 2017 •
edited

Motivation for this change

I messed this up when I moved the logic from makeStdenvCross in e826a6a.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
stdenv: Add back leading '-' in cross derivation name suffix
51179c6 
I messed this up when I moved the logic from `makeStdenvCross` in
e826a6a.
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Sep 18, 2017
@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @orivej and @dezgeg to be potential reviewers.

@Ericson2314 Ericson2314 merged commit 807d8ce into NixOS:master Sep 18, 2017
@Ericson2314 Ericson2314 deleted the cross-suffix branch September 18, 2017 23:20
Ericson2314 added a commit that referenced this pull request Sep 19, 2017
@Ericson2314
Merge master-merged PRs #29547 and #29548 into staging
d403ffe
@Ericson2314 Ericson2314 added this to Needed for binutils-wrapper in Cross compilation Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on
Projects
No open projects
Cross compilation
Needed for binutils-wrapper
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @mention-bot @matthewbauer