Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitolite: use group 'gitolite' instead of 'nogroup' #29267

Closed
wants to merge 1 commit into from
Closed

nixos/gitolite: use group 'gitolite' instead of 'nogroup' #29267

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Having files (git repositories) owned by 'nogroup' is a bad idea.

Things done

I built a NixOS system with this patch applied. /var/lib/gitolite is now owned by "gitolite" instead of "nogroup".

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
nixos/gitolite: use group 'gitolite' instead of 'nogroup'
1118ef4 
Having files (git repositories) owned by 'nogroup' is a bad idea.
@bjornfor
Copy link
Contributor Author

Applied to master (3a58e41) and release-17.09 (1cdb055).

@bjornfor bjornfor closed this Sep 23, 2017
@bjornfor bjornfor deleted the nixos-gitolite branch October 8, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bjornfor