Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make my maintainer handle match my github username #29263

Merged
merged 1 commit into from Sep 13, 2017

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Sep 12, 2017

Motivation for this change

Request by @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jyp jyp requested a review from edolstra as a code owner September 12, 2017 08:04
@jyp jyp mentioned this pull request Sep 12, 2017
1 task
@Mic92
Copy link
Member

Mic92 commented Sep 12, 2017

Please also update the following files:

$ ag jpbernardy
pkgs/development/libraries/science/math/cudnn/8.0-6.0/default.nix
38:    maintainers = with maintainers; [ jpbernardy ];
pkgs/development/python-modules/bz2file/default.nix
23:    maintainers = with lib.maintainers; [ jpbernardy ];
pkgs/development/python-modules/tensorflow/default.nix
122:    maintainers = with maintainers; [ jpbernardy ];
pkgs/development/python-modules/gensim/default.nix
41:    maintainers = with lib.maintainers; [ jpbernardy ];
pkgs/development/python-modules/smart_open/default.nix
26:    maintainers = with lib.maintainers; [ jpbernardy ];
pkgs/development/python-modules/backports_weakref/default.nix
31:    maintainers = with maintainers; [ jpbernardy ];

@jyp
Copy link
Contributor Author

jyp commented Sep 12, 2017

argh, sorry about this.

Should be fine now.

@FRidh FRidh merged commit 7aa2e6b into NixOS:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants