Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing service_executor #2902

Merged
merged 2 commits into from Sep 15, 2017
Merged

Fixing service_executor #2902

merged 2 commits into from Sep 15, 2017

Conversation

sithhell
Copy link
Member

The destructor and thread_wrapper of the service_executor might race for
completion. This patch ensures that the thread_wrapper always completes
before the destructor

Fixing service_executor
2c6e61f 
The destructor and thread_wrapper of the service_executor might race for
completion. This patch ensures that the thread_wrapper always completes
before the destructor
@sithhell sithhell added this to the 1.1.0 milestone Sep 12, 2017
hkaiser
hkaiser approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sithhell sithhell merged commit 9c81e74 into master Sep 15, 2017
@sithhell sithhell deleted the fix_service_executor branch September 15, 2017 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkaiser hkaiser hkaiser approved these changes

Assignees
No one assigned
Labels
category: executors type: race condition
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sithhell @hkaiser