Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test opening encrypted filesystem with keyfile #29269

Merged
merged 1 commit into from Nov 19, 2017

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Sep 12, 2017

Motivation for this change

Tests for missing cryptsetup in initrd when only encrypted filesystems with keyfiles are configured (see issue #29142).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Moredread, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @dezgeg to be potential reviewers.

@Moredread
Copy link
Contributor Author

It fails at the moment due to the issue above, I'll add a PR later with a fix for the issue. But please have a look already, as it is the first time for me working with the test system.

Are the names I used in the tests OK? Is putting the test in installer.nix a good idea (I need to set up the filesystems before the machine boots, and didn't want to duplicate the complex machine setup in installer.nix).

@Moredread
Copy link
Contributor Author

@fpletz ping

@bachp
Copy link
Member

bachp commented Sep 12, 2017

@Moredread I'm also not too familiar with the testing system, but as your test is kind of related to the looksroot, I think it makes sense to put it there.

BTW do you already have an ETA for your fix PR? I just ran into the same issue.

@Moredread
Copy link
Contributor Author

@bachp I'm planning on working on it tomorrow.

Checks for regression of missing cryptsetup, when no luks device without
keyfile is configured
@joachifm joachifm added this to the 17.09 milestone Sep 17, 2017
@fpletz fpletz merged commit bdbaaad into NixOS:master Nov 19, 2017
@Moredread Moredread deleted the test_crypt_with_keyfile branch February 5, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants