Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeFrameworks: 5.37 -> 5.38 #29277

Merged
merged 1 commit into from Sep 13, 2017
Merged

kdeFrameworks: 5.37 -> 5.38 #29277

merged 1 commit into from Sep 13, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 12, 2017 •
edited

Motivation for this change

Nox-review is still running.
@ttuegel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@bkchr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vandenoever and @ttuegel to be potential reviewers.

@FRidh FRidh requested a review from ttuegel September 12, 2017 20:09
@bkchr
Copy link
Contributor Author

bkchr commented Sep 13, 2017

nox-review does not reported any errors :)

@ttuegel
Copy link
Member

ttuegel commented Sep 13, 2017

If nox-review didn't get stuck on an unrelated change, that itself is a small miracle! I'm checking the NixOS tests now.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 13, 2017

Yeah, miracles! :D I took quite a lot of time to compile all these dependent packages on my laptop^^ Is there a specific test for the kde frameworks stuff? If yes, how can I run this test locally?

@ttuegel
Copy link
Member

ttuegel commented Sep 13, 2017

There is no Frameworks-specific test, but the Plasma tests should exercise the important parts:

nix-build nixos/release-combined.nix -A nixos.tests.plasma5.x86_64-linux

@ttuegel ttuegel merged commit 54f2db5 into NixOS:master Sep 13, 2017
@bkchr bkchr deleted the kde_frameworks_5_38 branch September 13, 2017 14:04
@bkchr
Copy link
Contributor Author

bkchr commented Sep 13, 2017

Ahh nice, ty.

@ttuegel ttuegel mentioned this pull request Sep 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @mention-bot @ttuegel @FRidh