Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: 1.15.1 -> 1.16.0 #29127

Merged
merged 1 commit into from Sep 9, 2017
Merged

vscode: 1.15.1 -> 1.16.0 #29127

merged 1 commit into from Sep 9, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benley, @jgillich and @uralbash to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Sep 8, 2017

After applying this update, vscode no longer creates a graphical window.
The background process exists though:

$ code
$ ps aux | grep code
joerg    20852  8.2  0.7 1260488 58880 ?       Ssl  18:36   0:00 /nix/store/bc4ypzd896pi73by7cfjbmwa2kpv7gai-vscode-1.16.0/lib/vscode/code --skip-getting-started
joerg    20868  1.7  0.2 477248 20708 ?        S    18:36   0:00 /nix/store/bc4ypzd896pi73by7cfjbmwa2kpv7gai-vscode-1.16.0/lib/vscode/code --type=zygote --no-sandbox
joerg    20896  2.5  0.3 510552 26816 ?        Sl   18:36   0:00 /nix/store/bc4ypzd896pi73by7cfjbmwa2kpv7gai-vscode-1.16.0/lib/vscode/code --type=gpu-process --no-sandbox --supports-dual-gpus=false --gpu-driver-bug-workarounds=7,23,74 --disable-gl-extensions=GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent --gpu-vendor-id=0x0000 --gpu-device-id=0x0000 --gpu-driver-vendor --gpu-driver-version --gpu-driver-date --service-request-channel-token=AB42B1
joerg    20998  0.0  0.0 119832  1436 pts/5    S+   18:36   0:00 grep --binary-files=without-match --directories=skip --color=auto code

@NeQuissimus
Copy link
Member Author

@Mic92 huh, I will take a look, it started fine for me...

@NeQuissimus
Copy link
Member Author

Ah, I remember now.

I hadn't wanted to push a weird hack. Can you take a look at my patchelf I am adding? That file needs to know about libsecret but the patchelf does not work. The ln does but I didn't want to PR that solution...

@Mic92
Copy link
Member

Mic92 commented Sep 9, 2017

now it works

@Mic92 Mic92 merged commit 981728d into NixOS:master Sep 9, 2017
@NeQuissimus NeQuissimus deleted the vscode_1_16_0 branch September 9, 2017 13:42
worldofpeace added a commit to eadwu/nixpkgs that referenced this pull request Feb 10, 2019
@worldofpeace
vscode: minor cleanup, produce one wrapper on linux
3513063 
I removed the hack for libsecret, introduced in[0] and
I didn't encounter any problems at runtime.

[0]: NixOS#29127
worldofpeace added a commit that referenced this pull request Feb 10, 2019
@worldofpeace
vscode: minor cleanup, produce one wrapper on linux
d9b1486 
I removed the hack for libsecret, introduced in[0] and
I didn't encounter any problems at runtime.

[0]: #29127
eadwu pushed a commit to eadwu/nixpkgs that referenced this pull request Feb 10, 2019
@worldofpeace @eadwu
vscode: minor cleanup, produce one wrapper on linux
2368993 
I removed the hack for libsecret, introduced in[0] and
I didn't encounter any problems at runtime.

[0]: NixOS#29127

(cherry picked from commit d9b1486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (update) 9.needs: community feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NeQuissimus @mention-bot @Mic92