Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KdeApplications: 17.08.0 --> 17.08.1 #29117

Merged
merged 1 commit into from Sep 11, 2017
Merged

KdeApplications: 17.08.0 --> 17.08.1 #29117

merged 1 commit into from Sep 11, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 8, 2017 •
edited

Motivation for this change

nox-review still running.

@ttuegel

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested a review from ttuegel September 8, 2017 19:07
ttuegel
ttuegel requested changes Sep 9, 2017
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but please retitle your commit to match convention, i.e. kdeApplications: 17.08.0 -> 17.08.1.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 10, 2017

Updated :)

@ttuegel ttuegel merged commit 6299659 into NixOS:master Sep 11, 2017
@ttuegel
Copy link
Member

ttuegel commented Sep 11, 2017

Thanks!

ttuegel pushed a commit that referenced this pull request Sep 11, 2017
@ttuegel
Merge pull request #29117 from bkchr/kde_applications_17_08_1
7921852 
kdeApplications: 17.08.0 -> 17.08.1
(cherry picked from commit 6299659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @ttuegel @FRidh