Moe: init at 1.9 #29114
Moe: init at 1.9 #29114
Conversation
|
| version = "1.9"; | ||
|
|
||
| src = fetchurl{ | ||
| url = "http://ftp.gnu.org/moe/${name}.tar.lz"; |
| name = "moe-${version}"; | ||
| version = "1.9"; | ||
|
|
||
| src = fetchurl{ |
| sha256 = "1wsfzy0iia0c89wnx1ilzw54wqcmlp2nz8mkpvc393z0zagrx48q"; | ||
| }; | ||
|
|
||
| buildInputs = [ lzip ncurses ]; |
There was a problem hiding this comment.
lzip should be nativeBuildInput if it is only used to unpack the tarball
| delimiter matching, text conversion from/to UTF-8, romanization, etc. | ||
| ''; | ||
| homepage = http://www.gnu.org/software/moe/; | ||
| license = licenses.gpl3Plus; |
There was a problem hiding this comment.
According to the text of the homepage, the license is gpl2plus.
| homepage = http://www.gnu.org/software/moe/; | ||
| license = licenses.gpl3Plus; | ||
| maintainers = with maintainers; [ AndersonTorres ]; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
On macOS (aka darwin), build fails with:
c++ -O2 -c -o window_vector.o window_vector.cc
window_vector.cc:1033:21: error: call to member function 'insert' is ambiguous
{ year_string.insert( 0U, 1, '0' + ( year % 10 ) ); year /= 10; }
~~~~~~~~~~~~^~~~~~
A possible work-around is to declare a less general platform.
There was a problem hiding this comment.
Is it triggered only in clang?
There was a problem hiding this comment.
Either that or this code is not compiled on Linux.
|
I think everything is OK now. |
| }: | ||
|
|
||
| with stdenv.lib; | ||
| stdenv.mkDerivation rec{ |
There was a problem hiding this comment.
Put a space between rec and { here. (Just for style though I think.)
There was a problem hiding this comment.
rec is reserved word. It is really necessary?
Maybe in a short future we would need to standardize the nix(pkgs) programming style.
P.S.: as a curiousity, I ran the commands above:
- 0 space:
git grep 'rec{' | wc -l=> 40 - 1 space:
git grep 'rec {' | wc -l=> 10111
There was a problem hiding this comment.
Oh I'm not sure I just thought this was a typo.
| sha256 = "1wsfzy0iia0c89wnx1ilzw54wqcmlp2nz8mkpvc393z0zagrx48q"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ lzip ] |
There was a problem hiding this comment.
Oh man, I was very distracted yesterday.
Moe is a small text editor.
Moe is a small text editor.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)