Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gst-python's pygi overrides dir #29131

Closed
wants to merge 2 commits into from
Closed

Conversation

rycee
Copy link
Member

@rycee rycee commented Sep 8, 2017

Motivation for this change

To properly fix the issue brought up in #29126.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Before it created a lib directory inside the lib directory.
With gst-python installing in the right library path, Pitivi is able
to find it out of the box.
@rycee rycee requested a review from FRidh September 8, 2017 19:48
@FRidh FRidh self-assigned this Sep 8, 2017
@FRidh
Copy link
Member

FRidh commented Sep 8, 2017

Thanks. Pushed to master and will push to 17.09 as well.

@FRidh FRidh closed this Sep 8, 2017
@rycee rycee deleted the fix/gst-python branch September 8, 2017 19:58
@rycee
Copy link
Member Author

rycee commented Sep 8, 2017

Cool. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants