Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcomix: fixup #29116

Merged
merged 1 commit into from Sep 8, 2017
Merged

mcomix: fixup #29116

merged 1 commit into from Sep 8, 2017

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Sep 8, 2017

Also, adding myself to maintainers list.

Motivation for this change

MComix is failing in the check phase; so, we'll not check it.

Fixes #28643 (ZHF-17.09)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

MComix is failing in the check phase; so, we'll not check it.
@globin globin merged commit f93a019 into NixOS:master Sep 8, 2017
@AndersonTorres AndersonTorres deleted the upload/mcomix branch February 23, 2018 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants