sddm: 0.14.0 -> 0.15.0 #29129
Merged
sddm: 0.14.0 -> 0.15.0 #29129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jokogr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @abbradar and @infinisil to be potential reviewers. |
ttuegel
requested changes
Sep 9, 2017
| }; | ||
|
|
||
| patches = | ||
| copyPathsToStore (lib.readPathsFromFile ./. ./series) |
There was a problem hiding this comment.
Are you removing patchFixUserAvatars because it was accepted upstream?
You also removed sddm-ignore-config-mtime.patch which is Nixpkgs-specific. I think we still need this. If you intended to remove it, please also remove the patch file.
There was a problem hiding this comment.
I stand corrected:
patchFixUserAvatarshas indeed been accepted upstreamsddm-ignore-config-mtime.patchis still needed
I have fixed it, tested it and rebased the PR to the current master.
jokogr
force-pushed
the
u/sddm-0.15.0
branch
from
ce21792
to
01b4c3c
Compare
ttuegel
approved these changes
Sep 11, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream update
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)