MBS-9353: Fix RequireAuth attributes for user profile and collection #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ff7825. Attribute 'RequireAuth' of 'base' subroutine is not inherited by other subroutines which are chained to 'load' rather than 'base'. Explicit 'RequireAuth' attribute per subroutine to be added next.
mwiencek
requested changes
Aug 21, 2017
| @@ -465,7 +465,7 @@ sub tag : Chained('load') PathPart('tag') Args(1) | |||
| ); | |||
| } | |||
|
|
|||
| sub privileged : Path('/privileged') | |||
There was a problem hiding this comment.
I don't think we need/ought to RequireAuth for /privileged.
There was a problem hiding this comment.
That was completely unnecessary and is reverted in 69d3c67
Explicitly require auth for each subpath.
yvanzo
force-pushed
the
mbs-9353-auth-user-profile
branch
from
9dad8f8
to
9d8d616
Compare
mwiencek
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBS-9353: Do not show collections or user profiles to people not logged in
Set
RequireAuthattribute to every subroutine of Collection & User rather thanbasesubroutine.