Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonpackages.thrift: 0.9.3 -> 0.10.0 #28507

Closed
wants to merge 2 commits into from
Closed

pythonpackages.thrift: 0.9.3 -> 0.10.0 #28507

wants to merge 2 commits into from

Conversation

pmiddend
Copy link
Contributor

Motivation for this change

thrift-0.10.0 was released some time ago.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner August 23, 2017 14:42
@bjornfor
Copy link
Contributor

Please change commit message part "increase version to 0.10.0" to "0.9.3 -> 0.10.0".

@FRidh FRidh changed the title pythonpackages.thrift: increase version to 0.10.0 pythonpackages.thrift: 0.9.3 -> 0.10.0 Aug 24, 2017
@Mic92
Copy link
Member

Mic92 commented Aug 25, 2017 •
edited

We also need the old version 0.9 as this is needed for pycassa

This package can be called thrift_0_9 in python-packages.nix

@FRidh
Copy link
Member

FRidh commented Aug 25, 2017

Let's not have multiple versions of one package inside python-packages.nix, because that will open the possibility again for collisions.

If our current packages break with the new version, then I think we should stick with the current version of thrift, unless its very outdated/broken/insecure.

@flokli
Copy link
Contributor

flokli commented Nov 29, 2017

@FRidh Does this mean this PR should be closed?

Currently, the situation is a bit of a mess, as there is (latest) thrift in top-level (with the python-bindings inside, too), and the (older) thrift in python2Packages, and it's not really obvious it is like that.

Maybe the python bindings should be split out of the thrift top-level package (and moved to pythonPackages.thrift), and the old thrift bindings hidden somewhere iside a let-expression or an override, if thrift_0_9 in pythonPackages is not desired.

The issue in cassandra is tracked here: pycassa/pycassa#245

@FRidh
Copy link
Member

FRidh commented Dec 5, 2017 •
edited

@flokli how is the python-packages.nix version supposed to work if it doesn't depend at all on the library in all-packages.nix?

@FRidh
Copy link
Member

FRidh commented Feb 11, 2018

Closing because of inactivity.

@FRidh FRidh closed this Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmiddend @bjornfor @Mic92 @FRidh @flokli