Fix MDLV2000WriterTest #359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally the writer should be generating consistent line endings '\n' independant of the system. Unfortunately the default java writers don't have this option but we can add that in. |
|
OK. We may modify writer.newline() to write('\n') and fix tests in MDLV2000WriterTest using toString().split(System.getProperty("line.separator") . |
|
Sounds good, are you okay to do that? |
|
Yes. I'll commit it later. |
|
Thanks |
|
I made a new pull request about this issue at #360. Please check it out. |
|
Presume these now pass on windows? I'm getting a failure in cdk-builder3d but think it's easy to resolve. |
|
Never mind... that builder3d failure was me being stricter on mass deltas, will fix |
|
resolved by #360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is failed on Windows because a new line chars are '\n' in this test but MDLV2000Writer creates '\r\n' eol on Windows.