-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fusion inventory: Init at 2.3.18 #28503
Conversation
@phile314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
}; | ||
|
||
servers = mkOption { | ||
type = types.listOf types.string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use types.str
services.fusionInventory = { | ||
|
||
enable = mkOption { | ||
default = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please declare a type.
@@ -0,0 +1,67 @@ | |||
{ stdenv, fetchurl, gnused, buildPerlPackage, perl, perlPackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gnused
and perl
parameters appear to be unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the last nitpick I have on this :)
c41c5bf
to
00bc46b
Compare
Rebased it on current nixos-unstable. Can we merge this? |
Thanks 👍 |
Motivation for this change
Adds a package for the fusion inventory software and the corresponding NixOS service. Fusion Inventory is a monitoring agent.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)