Fusion inventory: Init at 2.3.18 #28503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phile314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers. |
joachifm
reviewed
Aug 23, 2017
| }; | ||
|
|
||
| servers = mkOption { | ||
| type = types.listOf types.string; |
joachifm
reviewed
Aug 23, 2017
| services.fusionInventory = { | ||
|
|
||
| enable = mkOption { | ||
| default = false; |
joachifm
reviewed
Aug 26, 2017
| @@ -0,0 +1,67 @@ | |||
| { stdenv, fetchurl, gnused, buildPerlPackage, perl, perlPackages | |||
There was a problem hiding this comment.
The gnused and perl parameters appear to be unused.
There was a problem hiding this comment.
That's the last nitpick I have on this :)
phile314
force-pushed
the
fusion-inventory
branch
from
c41c5bf
to
00bc46b
Compare
|
Rebased it on current nixos-unstable. Can we merge this? |
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds a package for the fusion inventory software and the corresponding NixOS service. Fusion Inventory is a monitoring agent.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)