Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus-anthy: fix pygobject3 dependency #29376

Merged
merged 1 commit into from Sep 27, 2017
Merged

Conversation

lsix
Copy link
Member

@lsix lsix commented Sep 14, 2017

Motivation for this change

This should fix #29275 . Once accepted this should be ported to release-17.09.

I have only built the package and not tested it at runtime.

thanks @teto for the pointer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @gebner and @ericsagnes to be potential reviewers.

@lsix lsix added this to the 17.09 milestone Sep 25, 2017
@globin globin merged commit be697dc into NixOS:master Sep 27, 2017
lukateras added a commit to lukateras/nixpkgs that referenced this pull request Oct 10, 2017
Mic92 pushed a commit that referenced this pull request Oct 13, 2017
Analogous to #29376.

(cherry picked from commit f78aca5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese input no longer works on 17.09 beta whereas it did on 17.03 stable
4 participants