Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 359ede1d7299
Choose a base ref
...
head repository: NixOS/nix
compare: 89dc62c17459
Choose a head ref
  • 5 commits
  • 9 files changed
  • 1 contributor

Commits on Sep 14, 2017

  1. nix why-depends: Fix showing self-references

    @edolstra
    edolstra committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    1c58ad2 View commit details
    Browse the repository at this point in the history

  2. Add "nix add-to-store" command

    @edolstra
    edolstra committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    9703662 View commit details
    Browse the repository at this point in the history

  3. nix-store -q --roots / --gc --print-roots: Print temporary / in-memor… 

    …y roots

For example,

  $ nix-store -q --roots /nix/store/7phd2sav7068nivgvmj2vpm3v47fd27l-patchelf-0.8pre845_0315148
  {temp:1}

denotes that the path is only being kept alive by a temporary root
(i.e. /nix/var/nix/temproots/). Similarly,

  $ nix-store --gc --print-roots
  ...
  {memory:9} -> /nix/store/094gpjn9f15ip17wzxhma4r51nvsj17p-curl-7.53.1

shows that curl is being used by some process.
    @edolstra
    edolstra committed Sep 14, 2017
    1 Configuration menu
    Copy the full SHA
    da1e4fd View commit details
    Browse the repository at this point in the history

  4. Show the pid of temporary roots

    @edolstra
    edolstra committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    308ecf6 View commit details
    Browse the repository at this point in the history

  5. RemoteStore: Add option to drop old connections from the pool 

    This is a hack to make hydra-queue-runner free its temproots
periodically, thereby ensuring that garbage collection of the
corresponding paths is not blocked until the queue runner is
restarted.

It would be better if temproots could be released earlier than at
process exit. I started working on a RAII object returned by functions
like addToStore() that releases temproots. However, this would be a
pretty massive change so I gave up on it for now.
    @edolstra
    edolstra committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    89dc62c View commit details
    Browse the repository at this point in the history