Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 112e3655a8a0
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cdb9423f08c7
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 28, 2017

  1. Doco.

    headius committed Aug 28, 2017
    Copy the full SHA
    02169fa View commit details
  2. Copy the full SHA
    5ff7385 View commit details
  3. Copy the full SHA
    cdb9423 View commit details
Showing with 3 additions and 2 deletions.
  1. +1 −0 core/src/main/java/org/jruby/ir/IRBuilder.java
  2. +1 −1 lib/ruby/stdlib/date.rb
  3. +1 −1 test/mri/excludes/TestDateConv.rb
1 change: 1 addition & 0 deletions core/src/main/java/org/jruby/ir/IRBuilder.java
Original file line number Diff line number Diff line change
@@ -1049,6 +1049,7 @@ public Operand buildCall(Variable result, CallNode callNode) {
Operand receiver = buildWithOrder(receiverNode, callNode.containsVariableAssignment());
if (result == null) result = createTemporaryVariable();

// obj["string"] optimization for Hash
ArrayNode argsAry;
if (
!callNode.isLazy() &&
2 changes: 1 addition & 1 deletion lib/ruby/stdlib/date.rb
Original file line number Diff line number Diff line change
@@ -1934,7 +1934,7 @@ def self.now(sg=ITALY)
class DateTime < Date

def to_time
Time.new(year, mon, mday, hour, min, sec + sec_fraction, (@of * 86400).to_i).getlocal
Time.new(year, mon, mday, hour, min, sec + sec_fraction, (@of * 86400.0))
end

def to_date
2 changes: 1 addition & 1 deletion test/mri/excludes/TestDateConv.rb
Original file line number Diff line number Diff line change
@@ -1 +1 @@
exclude :test_to_time__from_datetime, "rational precision issue of some kind"
exclude :test_to_time__from_datetime, "subsecond time is not preserved in rational as in MRI"