Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

palemoon: 27.4.1 -> 27.4.2 #29511

Merged
merged 1 commit into from Sep 18, 2017
Merged

palemoon: 27.4.1 -> 27.4.2 #29511

merged 1 commit into from Sep 18, 2017

Conversation

MDeltaX
Copy link

@MDeltaX MDeltaX commented Sep 18, 2017

GCC - Minimum version required is 4.7. Version 4.9 is recommended, and versions 5.x and 6.x are still experimental.
https://developer.palemoon.org/Developer_Guide:Build_Instructions/Pale_Moon/Linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [] NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@koenigmaximilian, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bjornfor, @rnhmjoj and @calvertvl to be potential reviewers.

@MDeltaX
Copy link
Author

MDeltaX commented Sep 18, 2017

@joachifm

@fpletz fpletz added this to the 17.09 milestone Sep 18, 2017
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works for me. Thanks!

@fpletz fpletz merged commit 460cd80 into NixOS:master Sep 18, 2017
@MDeltaX MDeltaX deleted the palemoon branch October 18, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants