Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds windows build #4790

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adds windows build #4790

wants to merge 1 commit into from

Conversation

mkristian
Copy link
Member

@enebo this is a way to attach an extra artifact. see the maven/jruby-windows/pom.rb to adjust it to pick the 'real' file or even trigger the build of the real file if this is possible. any questions or if you want to include it somewhere differently then let's discuss it on this PR

@headius
Copy link
Member

headius commented Oct 31, 2017

I have added checksum generation to the release artifacts in 3b17b3b and modified the post_process_artifacts target to also generate sha-512 for the installer. The new installer setup will need to also generate these checksums.

@enebo
Copy link
Member

enebo commented Dec 4, 2019

@mkristian I picked this up and started to work on it. Besides figuring out how to redo building the installers from maven (which will at some level just be new contents in pom.rb files) I have some questions:

if I run what was the first pass I error on:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-install-plugin:2.4:install (default-install) on project jruby-windows: Failed to install artifact org.jruby:jruby-windows:jar:sources:9.2.10.0-SNAPSHOT: /home/enebo/work/jruby/maven/jruby-windows/src/empty.jar (No such file or directory) -> [Help 1]

and I see:

  # we have no sources and attach an empty jar later in the build to
  # satisfy oss.sonatype.org upload
  plugin( :source, 'skipSource' =>  'true' )

So what should happen here to make the empty jar?

My other immediate question is since we have 2 installers (32 and 64 bits). We will need to have 2 jruby-windows subdirs right? I am thinking jruby-windows and jruby-windows-32.

@mkristian mkristian mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants