Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esptool: 1.3 -> 2.1 #29512

Merged
merged 1 commit into from Sep 18, 2017
Merged

esptool: 1.3 -> 2.1 #29512

merged 1 commit into from Sep 18, 2017

Conversation

dotlambda
Copy link
Member

Motivation for this change

New version available which adds support for the ESP32.
Now, the tests using flake8 are also enabled.
I even tested the upload of some binaries to a real-world ESP8266.

If you want, I can also refactor the derivation to use fetchPypi and call it in python-packages.nix instead of all-packages.nix. Just let me know if that's desired.

@dezgeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg dezgeg merged commit 7f89abd into NixOS:master Sep 18, 2017
@dezgeg
Copy link
Contributor

dezgeg commented Sep 18, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants