Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Remove openldap dependency #29523

Merged
merged 1 commit into from Sep 18, 2017

Conversation

aneeshusa
Copy link
Contributor

Motivation for this change

The openldap dependency is only used for the audisp z/OS plugin.
This is not useful on Linux, so always disable this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@aneeshusa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @globin to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Sep 18, 2017

Can you change the target branch of this pull request to staging?

@aneeshusa aneeshusa changed the base branch from master to staging September 18, 2017 09:48
The openldap dependency is only used for the audisp z/OS plugin.
This is not useful on Linux, so always disable this.
@aneeshusa aneeshusa force-pushed the audit-remove-openldap-dependency branch from 6fdb7d3 to 49fc06e Compare September 18, 2017 09:49
@Mic92 Mic92 merged commit b89c3af into NixOS:staging Sep 18, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 18, 2017

Thanks!

@aneeshusa aneeshusa deleted the audit-remove-openldap-dependency branch January 7, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants