libevent: Make OpenSSL dependency optional #29522
Conversation
|
|
|
@Mic92 But this change shouldn't change the hash of libevent? |
|
|
||
| buildInputs = [ openssl ] ++ stdenv.lib.optional stdenv.isCygwin findutils; | ||
| buildInputs = [] | ||
| ++ stdenv.lib.optional enableOpenssl "openssl" |
There was a problem hiding this comment.
openssl shouldn't be a string here but the reference to the package. 😉
There was a problem hiding this comment.
Oops, you can tell I never actually tried this with openssl enabled...thanks for catching that.
| @@ -1,4 +1,9 @@ | |||
| { stdenv, fetchurl, openssl, findutils }: | |||
| { | |||
| stdenv, fetchurl, findutils, | |||
There was a problem hiding this comment.
This formatting is a bit unusual. Typically the comma is at the beginning of the line. Something like
{ stdenv, fetchurl, findutils
, enableOpenssl ? true, openssl
}:
There was a problem hiding this comment.
I've seen the comma go both at the beginning and the end and I also find it a bit unbalanced to have a bunch of items on the first line with the open bracket but none on the last line with the close bracket. That being said, it's a minor quibble so I've changed to your recommendation here.
| { stdenv, fetchurl, openssl, findutils }: | ||
| { | ||
| stdenv, fetchurl, findutils, | ||
| enableOpenssl? true, openssl |
There was a problem hiding this comment.
It seems that sslSupport is more commonly used in Nixpkgs. So I would suggest to use sslSupport ? true here.
aneeshusa
force-pushed
the
libevent-make-openssl-dependency-optional
branch
from
fb8be58
to
42a8ac1
Compare
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)