Skip to content

Fix RnDFixer #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 17, 2017
Merged

Fix RnDFixer #229

merged 7 commits into from
Sep 17, 2017
+97 −53

Conversation

Sigma88
Copy link
Contributor

@Sigma88 Sigma88 commented Sep 17, 2017

this fixes numerous issues with RnDFixer:

  • fixed reflection of method "AddPlanets" that was not working
  • added checks to catch errors more easily
  • changed all foreach to for to improve performance
  • removed namechanger code from RnDFixed (not necessary anymore)

also, now using cbNameLater will set the displayName as well

@Sigma88
make code more solid

Unverified

No user is associated with the committer email.
Learn about vigilant mode
f8b7ebb
@Sigma88
use correct name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
da2484b
@Sigma88
names don't work apparently

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
df547c4
@Sigma88
indentation
3d111dc
@Sigma88
solve lots of issues
c1d8422
@Sigma88
cbNameLater also changes displayName
0aad50a
@Sigma88
reminder
b606b0f
@Sigma88 Sigma88 merged commit 1e446c9 into master Sep 17, 2017
This was referenced Sep 17, 2017
Closed
Closed
@Sigma88 Sigma88 deleted the rndfixer branch September 21, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Sigma88