Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdata: 1.5.0 -> 1.7.0 #29498

Merged
merged 1 commit into from Sep 17, 2017
Merged

netdata: 1.5.0 -> 1.7.0 #29498

merged 1 commit into from Sep 17, 2017

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Sep 17, 2017

Updates netdata. Lots of improvements:

https://github.com/firehol/netdata/releases/tag/v1.6.0
https://github.com/firehol/netdata/releases/tag/v1.7.0

I have updated the web_access.patch but not changed its functionality.
I'm not sure it's needed anymore though, when I compiled without the patch Netdata still seemed to work fine with the NixOS service module. It's not clear to me what's supposedly broken without this patch. If the previous authors could explain or verify that would be great.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@yesbox, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cransom, @womfoo and @lethalman to be potential reviewers.

@fpletz fpletz merged commit 672ff71 into NixOS:master Sep 17, 2017
@yesbox yesbox deleted the netdata_1.7.0 branch February 4, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants