redis: 3.2.9 -> 4.0.1 #29516
Merged
redis: 3.2.9 -> 4.0.1 #29516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this but wonder if there should be a redis3 attribute for the 3.x version? |
|
The 4.x release doesn't break anything except that one change in the clustering protocol so I'm not sure that an attribute for redis3 is necessary. I have already deployed some projects on Redis 4 without any hiccups or code changes. |
|
Redis will be restarted on update in NixOS anyway. So this seems fine to me. |
|
Fair enough, but I think it would be prudent to put an entry in the release notes that this requires a cluster mass-restart since it'll be quite important for larger deploys (I'm not personally affected, though). Sorry about the long delay in coming back to this PR, btw! |
|
Done in 34750bb |
|
Thanks @globin! Much appreciated. |
globin
added a commit
that referenced
this pull request
Sep 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Redis 4.0 has been out for a while now and brings some nice additions:
Sadly the NAT feature brings an incompatible change to the Redis Cluster protocol so an existing cluster has to be mass-rebooted.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)