dockerTools.pullImage: use imageDigest #29505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker provides the "image digest" which is an immutable image identifier (unlike image name and tag). It now has to be specified to pull an image. Note Docker supports URI such as imageName:imageTag@imageDigest however this is not yet supported by Skopeo: "Docker references with both a tag and digest are currently not supported"
8 tasks
|
This looks fantastic, thanks! |
fpletz
approved these changes
Sep 18, 2017
|
Big fan of digests, so +1 from me. Can you also add a commit to remove the |
|
+1 also cc @offlinehacker and @matejc |
|
@aneeshusa oups... commit pushed. Thanks! |
|
Thanks @nlewo! I just noticed that |
|
@aneeshusa done. |
aneeshusa
approved these changes
Sep 20, 2017
domenkozar
approved these changes
Sep 28, 2017
|
Nice, looks good, thanks :) |
|
Since dockerTools.pull implementation with Skopeo has been reverted from master, this PR is deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker provides the "image digest" which is an immutable image
identifier (unlike image name and tag).
It now has to be specified to pull an image.
Note Docker supports URI such as imageName:imageTag@imageDigest however
this is not yet supported by Skopeo:
"Docker references with both a tag and digest are currently not supported"
Motivation for this change
This improve reproducibility of docker pullling operations since it now use a immutable Docker image identifier.
Things done
nix-build ./ -A dockerTools.examples.nix && docker load -i resultbuild-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)