Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDVisibility #227

Closed
Sigma88 opened this issue Sep 17, 2017 · 3 comments
Closed

RDVisibility #227

Sigma88 opened this issue Sep 17, 2017 · 3 comments

Comments

@Sigma88
Copy link
Contributor

Sigma88 commented Sep 17, 2017

seems like this feature isn't working anymore

(or I'm using it wrong)

RDVisibilityBug.zip
@Sigma88
Copy link
Contributor Author

Sigma88 commented Sep 17, 2017

correction: only SKIP doesn't work

@Sigma88
Copy link
Contributor Author

Sigma88 commented Sep 17, 2017

https://github.com/Kopernicus/Kopernicus/blob/master/Kopernicus/Kopernicus/RuntimeUtility/RnDFixer.cs#L207

this is the method that is causing issues, the issue is unrelated to SKIP.

triggering this method will result in nullrefs even if SKIP is not used

(I tried triggering the method at the beginning of Start() ) and it still broke

@Sigma88
Copy link
Contributor Author

Sigma88 commented Sep 17, 2017

I solved this with #229

@StollD I took the liberty of merging the PR since it contained mostly bug-fixes

if you don't like what you see just let me know

@Sigma88 Sigma88 closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sigma88