Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_client: Adds missing dependency #29520

Merged
merged 1 commit into from Sep 18, 2017
Merged

teamspeak_client: Adds missing dependency #29520

merged 1 commit into from Sep 18, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Sep 18, 2017 •
edited

Motivation for this change

I updated the teamspeak_client in the following pr #29500.
Today, I observed that the program is missing a dependency, this patch adds the dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@bkchr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nathanielbaxter, @DeltaEvo and @domenkozar to be potential reviewers.

@fpletz fpletz merged commit 34b1e4c into NixOS:master Sep 18, 2017
@bkchr bkchr deleted the teamspeak_3_1_6 branch September 18, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @mention-bot @fpletz