awesome: specify version #29510
Merged
awesome: specify version #29510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, awesome will use "devel" as a version name (or `git describe`). This has led to awesome always showing "devel" for its version. Some extensions depend on version information to figure out what features they can use. This change overrides the version for the build from the derivations' `version` attribute.
yrashk
added a commit
to yrashk/nix-config
that referenced
this pull request
Sep 17, 2017
This breaks some extensions Solution: override the derivation to specify it A pull request to nixpkgs has been sent NixOS/nixpkgs#29510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, awesome will use "devel" as a version name
(or
git describe). This has led to awesome alwaysshowing "devel" for its version.
Some extensions depend on version information to figure
out what features they can use.
This change overrides the version for the build from the
derivations'
versionattribute.Motivation for this change
See above. The first occurrence of an extension that depended on
awesome's version detection: deficient/calendar#3
Things done
./result/bin/)cc @ndowens