Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-gi: Include haskell-gi-overloading 0.0 #28957

Closed
wants to merge 1 commit into from

Conversation

hamishmack
Copy link
Contributor

Motivation for this change

Using this version turns off overloading in all the haskell-gi packages.
See haskell-gi/haskell-gi#107 for details.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Using this version turns off overloading in all the haskell-gi packages.
See haskell-gi/haskell-gi#107 for details.
@hamishmack
Copy link
Contributor Author

@peti does this look ok? Should we use 0.0.* or 0.* instead of 0.0 just in case?

@peti
Copy link
Member

peti commented Sep 8, 2017

I committed peti@2da2193 already, which will be merged to master in a day or two. The corresponding package should show up at the same time.

@peti peti closed this Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants