Slic3r: 1.2.9 -> 1.3.0-dev #28958
Slic3r: 1.2.9 -> 1.3.0-dev #28958
Conversation
|
@timor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bjornfor, @the-kenny and @bobvanderlinden to be potential reviewers. |
|
The CI build fails because of a dependency (Boost::Geometry::Utils) that cannot be built. This actually seems to be the same error that I had to fix in the Slic3r package, but I don't know how to fix it for Boost::Geometry::Utils. The problem is that the final linking step of the perl xs stuff is performed with "ld" instead of "g++" or "gcc". I fixed it in this PR for slic3r by manually exporting LD="g++", but it seems to be a general problem. The symptom is a compilation error with "undefined reference to __dso_handle". Edit: This has been addressed in c24820d |
| export SLIC3R_NO_AUTO=true | ||
| export PERL5LIB="./xs/blib/arch/:./xs/blib/lib:$PERL5LIB" | ||
| export LD=g++ |
There was a problem hiding this comment.
I would propose to change this line to:
export LD=$CXX
or
unset LD
both should work :)
timor
force-pushed
the
slic3r-1.3.0-dev
branch
from
e52015c
to
0895fa8
Compare
| @@ -11946,6 +11946,7 @@ let self = _self // overrides; _self = with self; { | |||
| description = "Networking constants and support functions"; | |||
| license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ]; | |||
| }; | |||
| doCheck = false; | |||
There was a problem hiding this comment.
Please add a comment explaining why the tests have been disabled.
There was a problem hiding this comment.
I am not sure myself, it seems that this is a pretty old issue (see 70f0d79), but I am unable to track what happened to those ancient disabled tests. Is there still a mechanism to disable only selected tests?
There was a problem hiding this comment.
Nixpkgs doesn't have any "builtin" to do that. You have to fix it yourself.
There was a problem hiding this comment.
for python we can disable using py.test, maybe perl has a similar tool? Otherwise sometimes deleting or patching can solve it.
| }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| version = "1.2.9"; | ||
| version = "1.3.0-dev"; |
There was a problem hiding this comment.
IMHO nixpkgs should package the latest releases from upstream. Version 1.3.0-dev is not a release.
There was a problem hiding this comment.
That is true. I asked upstream, and was told that a current version is recommended over release 1.2.9 for production use
timor
force-pushed
the
slic3r-1.3.0-dev
branch
from
0895fa8
to
55cf439
Compare
|
I've merged #28996 as that looks cleaner and wait for an upstream stable release for the changes here.. |
|
I picked "perl-ExtUtils-ParseXS: 3.24 -> 3.35" and "perl-ExtUtils-XSpp: 0.1700 -> 0.18" to master. |
|
Is pull request this now obsolete? |
|
According to upstream, Slic3r 1.3.0 is due Q4 2017, shall I create a new pull request then? |
|
Yes. |
Motivation for this change
Update Slic3r to a recent version. Should also fix one item from #28643
Things done
Upated relevant perl packages, updated build instructions for a recent development build of version 1.3.0, which is suggested over the old version 1.2.9
cc @bjornfor, @the-kenny
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)