Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty string as alias for --no-debug #4923

Merged
merged 1 commit into from
Sep 3, 2017
Merged

Remove empty string as alias for --no-debug #4923

merged 1 commit into from
Sep 3, 2017
+2 −2

Conversation

mverzilli
Copy link

@mverzilli mverzilli commented Sep 3, 2017 •
edited
Loading

This is a pretty dumb fix. Before this change:

$ crystal build --help
Usage: crystal build [options] [programfile] [--] [arguments]

Options:
    --cross-compile                  cross-compile
    -d, --debug                      Add full symbolic debug info
    , --no-debug                     Skip any symbolic debug info
   -D FLAG, --define FLAG           Define a compile-time flag
   (...)

After this change:

$ crystal build --help
Usage: crystal build [options] [programfile] [--] [arguments]

Options:
    --cross-compile                  cross-compile
    -d, --debug                      Add full symbolic debug info
    --no-debug                     Skip any symbolic debug info
   -D FLAG, --define FLAG           Define a compile-time flag
   (...)

Apart from that, calling crystal build "" would set the --no-debug flag.

@mverzilli mverzilli added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Sep 3, 2017
@RX14 RX14 merged commit 0c5a8d7 into master Sep 3, 2017
@RX14 RX14 added this to the Next milestone Sep 3, 2017
@asterite asterite deleted the fix/empty_no_debug_option_alias branch April 27, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mverzilli @RX14