Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderdoc: 0.34pre -> 0.91 #28950

Merged
merged 1 commit into from Nov 21, 2017
Merged

renderdoc: 0.34pre -> 0.91 #28950

merged 1 commit into from Nov 21, 2017

Conversation

jansol
Copy link
Contributor

@jansol jansol commented Sep 3, 2017 •
edited

Motivation for this change

Upstream got updated.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jansol, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer.

@jansol
Copy link
Contributor Author

jansol commented Sep 3, 2017

Couldn't test qrenderdoc since it apparently insists on building against Qt 5.9.0 whereas KDE plasma is using 5.9.1 and it claims those are not compatible. If someone knows how to work around that, any help is very appreciated.

@Mic92 Mic92 changed the title renderdoc: Update to 0.91 renderdoc: 0.34pre -> 0.91 Sep 12, 2017
@jansol
Copy link
Contributor Author

jansol commented Oct 1, 2017 •
edited

Figured out the Qt problem (mismanaged user channel was leaking) and everything's peachy again with #29790.

EDIT: now just gotta figure out why it didn't build on travis

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 21, 2017

This builds fine actually

Result in /tmp/nox-review-225khxqw
total 0
lrwxrwxrwx 1 demo users 58 22 nov.  00:10 result -> /nix/store/vw8zzbzp7315sl0mg2fpq71rwb238n7c-renderdoc-0.91

@c0bw3b c0bw3b merged commit 74d36c9 into NixOS:master Nov 21, 2017
@orivej
Copy link
Contributor

orivej commented Dec 10, 2017

This broke the sandboxed and Hydra builds because the package attempts to download files during the build: https://hydra.nixos.org/build/65599152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jansol @mention-bot @c0bw3b @orivej