New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install-nix: Advancement of destination folder creation means #1555
Conversation
There are 555 open issues. Thug Life! |
I think, every case when
Also, I don't think that script that writes WHY does it need sudo-permissions will be more trusted then current one (I'm speaking for myself here). I don't trust random curl|sh scripts, even if they post to Triying |
@danbst What are arguments for:
|
This is great, but let me repeat my point again, in detail: I'm talking about situation, when actual install script failed. Don't know why, probably user chose not to enter sudo password ( In that case, when actual install failure happened, it is good to explain user that if he can create and own I'm also 👍 on using su when sudo not found. |
|
Ok. I close this. |
This commit concentrates on streamlining
/nix
folder creation.As Nix installation can be launched from any user, on any distro, with
sudo
or not - here is universal code.sudo
installed. Before this we could not distinct whensudo
access failed itself and whensudo
is not installed. And now we can say that we looked andsudo
is not installed, and it is understandable why we ask him root password itself.sudo
access is passwordless, or not.3a. Passwordless: we can inform user that we used
sudo
.3b. With password: we explain to user why we need sudo access, and ask to enter password for that.
sudo
fails, we mention that it also can be due to user has no sudoers access. Nowadayssudo
pretends that password do not match, while in reality user has no sudoers access. The Onesudo
developer, - millert - made that change years ago to not inform hackers that user has nosudo
access, but those reports is written to logs. But admins/users also can be puzzled by that, especially if passwords/infrastructure is complex.su
.5a.And big volume of clean distributions (minimalist ones) doesn't have
sudo
supplied with a distro (Alpine, Arch, even Debian I think).5a. And we explain why installer asks for root password itself.
And, yes; solves #539. Now script not falls because
sudo
is not present, - it uses root, user rights orsu
.I looked though all 'install' bugs and that's all I found related, but I by the way triaged a handful for people bugs, old ones also.