gnome3.evolution-data-server: Re-add GNOME Online Accounts support #28955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jtojnar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @groxxda, @lheckemann and @globin to be potential reviewers. |
Merged
|
Testing the compilation. |
|
@teh can you take a look at this? Compiled just fine for me. Also I'd like to backport to 17.09. |
|
The change was actually introduced in the original PR by @lheckemann. Maybe he can provide a rationale for disabling GOA support. |
|
I seem to recall there being build issues, and my approach was mostly trial and error. Sorry I didn't comment it, because I'm pretty sure I did think "this can't be left as is"… If it's building with GOA now I'm sure it's fine. |
|
Yea, definitely should not be disabled. Thanks @jtojnar ! |
In NixOS#26879, GNOME Online Accounts support was removed resulting in repeated authentication prompts for users relying on services like Google Calendar. This commit removes the build flag that disabled the support.
|
Can we move this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In #26879, GNOME Online Accounts support was removed resulting in repeated authentication prompts for users relying on services like Google Calendar.
This commit removes the build flag that disabled the support.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)