Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome-doc-utils: fix build for store paths containing '+' character #29293

Merged
merged 1 commit into from Nov 27, 2017
Merged

gnome-doc-utils: fix build for store paths containing '+' character #29293

merged 1 commit into from Nov 27, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Sep 13, 2017 •
edited

Motivation for this change

https://bugzilla.gnome.org/show_bug.cgi?id=787606

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

this is a mass-rebuild

@mention-bot
Copy link

@veprbl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @7c6f434c and @urkud to be potential reviewers.

joachifm
joachifm reviewed Sep 13, 2017
View reviewed changes
pkgs/development/tools/documentation/gnome-doc-utils/default.nix Outdated
@@ -10,7 +10,14 @@ python2Packages.buildPythonApplication {
sha256 = "19n4x25ndzngaciiyd8dd6s2mf9gv6nv3wv27ggns2smm7zkj1nb";
};

buildInputs = [ libxslt pkgconfig ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for not treating pkgconfig as native? If it is used during the build, it probably should be native.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, I was not attentive.

@veprbl
Copy link
Member Author

veprbl commented Sep 13, 2017

Would you like me to retarget this towards staging?

@joachifm
Copy link
Contributor

If it's a large rebuild, sure. I'm not familiar with this package at all.

@veprbl veprbl changed the base branch from master to staging September 13, 2017 17:55
@veprbl veprbl changed the title gnome-doc-utils: fix build for stores containing '+' character gnome-doc-utils: fix build for store paths containing '+' character Sep 13, 2017
@vcunat vcunat self-assigned this Nov 27, 2017
@vcunat vcunat merged commit c66656a into NixOS:staging Nov 27, 2017
vcunat added a commit that referenced this pull request Nov 27, 2017
@vcunat
Merge #29293: gnome-doc-utils: fix for paths cont. '+'
fe812fd
@veprbl veprbl deleted the gdu_sed_fix branch December 1, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@veprbl @mention-bot @joachifm @vcunat @GrahamcOfBorg