Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the .nsapwn suffix to container settings files #29294

Closed
wants to merge 1 commit into from

Conversation

rdjy
Copy link
Contributor

@rdjy rdjy commented Sep 13, 2017

The suffix is required for the files to take effect,
see: man systemd.nspawn

Motivation for this change

The suffix is required for the files to take effect,
see: man systemd.nspawn

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The suffix is required for the files to take effect,
see: man systemd.nspawn
@mention-bot
Copy link

@rdjy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @groxxda, @Mic92 and @ericsagnes to be potential reviewers.

@joachifm
Copy link
Contributor

Is this the same as #27117?

@rdjy
Copy link
Contributor Author

rdjy commented Sep 14, 2017

Ah, yes, same thing. should have checked more carefully. closing this one...

@rdjy rdjy closed this Sep 14, 2017
@rdjy rdjy deleted the fix-nspawn branch September 15, 2017 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants