trollius 1.0.4 -> 2.1 #29281
Closed
trollius 1.0.4 -> 2.1 #29281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also restricts the set of supported Python versions to the list as supplied on trollius' homepage. See NixOS#29208
|
I tried doing a nox review with the patch from this PR applied, and other stuff broke (aiodns was the first package that failed to build). Since this is a band-aid, maybe just fixing the old version would be better in the interim and getting rid of it as soon as packages dependent on trollius are updated. Here's my PR: #29444 that fixes the old version. |
|
@disassembler I'm fine either way; I'm not particularly attached to my work, it was just something I started during the NixOS sprint in Amsterdam last week that I wanted to finish rather than throw away. |
|
Since @disassembler 's PR request has long been accepted I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also restricts the set of supported Python versions to the list as supplied on trollius' homepage.
See #29208
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)