Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piwik: 3.0.4 -> 3.1.0 #29288

Merged
merged 1 commit into from Sep 13, 2017
Merged

piwik: 3.0.4 -> 3.1.0 #29288

merged 1 commit into from Sep 13, 2017

Conversation

florianjacob
Copy link
Contributor

@florianjacob florianjacob commented Sep 12, 2017 •
edited

Motivation for this change

Upgrade fixes security vulnerabilities.
Besides, my patch for Nix was merged upstream and therefore could be removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@florianjacob
piwik: 3.0.4 -> 3.1.0
556dfed 
Patch for Nix was merged upstream and therefore could be removed.
@joachifm joachifm merged commit 34b4935 into NixOS:master Sep 13, 2017
@joachifm
Copy link
Contributor

Thank you. Picked to release also.

@florianjacob florianjacob deleted the piwik-3.1.0 branch September 13, 2017 21:24
@florianjacob
Copy link
Contributor Author

Splendid! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florianjacob @joachifm