Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build of python3Packages.spacy #29291

Merged
merged 1 commit into from Sep 13, 2017
Merged

Fix build of python3Packages.spacy #29291

merged 1 commit into from Sep 13, 2017

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Sep 12, 2017

Motivation for this change

ftfy package was added for spaCy and is only used by spaCy.

This change downgrades its version to meet the bounds specified by spaCy (>=4.4.2,<5.0.0).

Relevant to #28643.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change -- built python3Packages.spacy
  • Tested execution of all binary files -- ./result/bin/ftfy
  • Fits CONTRIBUTING.md.

/cc @sdll @FRidh

@rvl
pythonPackages.ftfy: 5.1.1 -> 4.4.3
566f5e9 
ftfy package was added for spaCy and is only used by spaCy.

This change downgrades its version to meet the bounds specified by
spaCy (>=4.4.2,<5.0.0).

Relevant to NixOS#28643.
@FRidh FRidh merged commit d6dec0a into NixOS:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvl @FRidh