Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspcud: add darwin platform support #29280

Merged
merged 1 commit into from Sep 12, 2017
Merged

aspcud: add darwin platform support #29280

merged 1 commit into from Sep 12, 2017

Conversation

winniequinn
Copy link
Contributor

@winniequinn winniequinn commented Sep 12, 2017

This works because gringo now builds on Darwin.

Motivation for this change

See #29251 for information on aspcud and its relation to opam on Darwin. I will follow up with the applicable OPAM changes after this PR Is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This works because `gringo` now builds on Darwin.
@mention-bot
Copy link

@winniequinn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hakuch and @grahamc to be potential reviewers.

@vbgl vbgl merged commit abeb6af into NixOS:master Sep 12, 2017
@winniequinn winniequinn deleted the aspcud-darwin branch September 23, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants