Adding missing support for throttling scheduler #2871
Merged
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code got lost while merging the resource partitioner. Those changes enable it again.
|
The throttling scheduler should be moved into user code. Not sure if this should be merged. |
|
The code is still there, if the policy is selected, the application will
fail. Since we currently depend on this code and have confidence that it's
working, it should really be merged. The current code is broken without
having an immediate alternative. I have no problem porting the code
properly eventually. I currently can't dedicate resources for that though.
|
|
I concur - We should consider removing the throttling code and putting it into user space for the project that makes use of it, but in the meantime, it is still in the main tree and fixing the command line option to set it is correct. A separate issue/PR should remove schedulers that are no longer needed. |
biddisco
approved these changes
Aug 31, 2017
|
The corresponding issue has been created (#2876). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code got lost while merging the resource partitioner. Those changes enable
it again.