Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: v0.4.13 -> v0.4.16 #28732

Merged
merged 2 commits into from
Aug 30, 2017
Merged

solc: v0.4.13 -> v0.4.16 #28732

merged 2 commits into from
Aug 30, 2017

Conversation

mbrock
Copy link
Contributor

@mbrock mbrock commented Aug 30, 2017

Also add the Z3 SMT solver as a dependency, since the new solc can use
it for checking assertions and stuff (which is awesome).

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mbrock
solc: v0.4.13 -> v0.4.16
159b3bb 
Also add the Z3 SMT solver as a dependency, since the new solc can use
it for checking assertions and stuff (which is awesome).
@mention-bot
Copy link

@mbrock, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dbrock and @vbgl to be potential reviewers.

@mbrock
Copy link
Contributor Author

mbrock commented Aug 30, 2017

Thanks @fpletz! The Travis errors look pretty obscure:

getting status of ‘/tmp/nix-build-nixpkgs-tarball-17.09pre1234.abcdef.drv-0/nixpkgs/pkgs/applications/window-managers/clfswm’: No such file or directory

Kind of feel like it's not related to my changes!

@fpletz
Copy link
Member

fpletz commented Aug 30, 2017

Yeah, that is unrelated to your changes.

@fpletz fpletz merged commit 3d107c1 into NixOS:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbrock @mention-bot @fpletz