-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weechat-matrix-bridge: init at 2017-03-28 #28738
Conversation
2dfe9c4
to
452318e
Compare
What is the process to load this module into weechat? |
I opened this PR because I always try to contribute the Nix expressions I built back to the ecosystem if possible. If I manage to build something usable, I'll submit another PR :-) |
btw the travis error seems quite unrelated. I shouldupdate my local |
+package.cpath = package.cpath .. ";__NIX_LIB_PATH__" | ||
+ | ||
local json = require 'cjson' -- apt-get install lua-cjson | ||
local olmstatus, olm = pcall(require, 'olm') -- LuaJIT olm FFI binding ln -s ~/olm/olm.lua /usr/local/share/lua/5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not this also require libolm
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, my current (testing) setup works without olm ATM.
Will update the expression as soon as I got time to :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@fpletz I created the following gist which contains the expression I'm currently using: https://gist.github.com/Ma27/153a2bd1089c284671d0018508c9c66e Would appreciate it if we could discuss about it, when we found a suitable solution for nixpkgs, I'll submit a PR :-) |
faf03b3
to
7431641
Compare
7431641
to
724a69f
Compare
Thanks! |
Unfortunately not with this patch directly. There's a difference between plugins and scripts in weechat and since weechat/weechat#971 it's now possible to search for plugins at multiple locations, e.g. |
You might want to use |
Care to elaborate? Weechat stores all of its data (except plugins since #25274) in
When I started working on this, it was just some crazy late-night experiment that was far too opinionated. It became a bit more usable for normal people, but I'm still not sufficiently confident to submit it to Furthermore I'm not sure if this is the way to go. In fact, there's #33523 which also uses Until then I'd use my weechat module, but I'd much rather reserve some time in the next months to implement it right for upstream :) |
On 18-08-27 04:58, Maximilian Bosch wrote:
> You might want to use symlinkJoin for that
Care to elaborate? Weechat stores all of its data (except plugins since #25274) in `~/.weechat` which is writable and can't be a store path.
If you reference to my (admittedly hacky) module, I didn't do this to keep the directories writable. When I add a simple script to test it, I don't want to have a readonly store path, but a writable directory with linked scripts (at least for now).
Yeah I was talking about that module. I didn't read it in detail so I didn't realize that you're writing to `~/.weechat`. I thought that all scripts had to be in one location but you could at least set that location. If thats not the case I understand why you didn't upstream it.
> Any reason you haven't upstreamed those changes yet?
When I started working on this, it was just some crazy late-night experiment that was far too opinionated. It became a bit more usable for normal people, but I'm still not sufficiently confident to submit it to `nixpkgs` upstream, since I still dislike the manual configuration of files like `irc.conf` or `weechat.conf`. Many scripts store their defaults in such files, having them read-only makes the setup significantly harder.
Makes sense. Those files should still be modifiable by the user.
Furthermore I'm not sure if this is the way to go. In fact, there's #33523 which also uses `screen` to allow `weechat` running on a different machine and access it via `ssh`.
It allows to configure using `/cmd foobar` through Nix (didn't know how to implement this some months ago 😅 ), however this is the better solution IMHO.
Regarding the scripts I'd prefer to implement a better resolution approach upstream which allows multiple directories to search for scripts, then we may have an even better approach for a declarative weechat configuration.
Until then I'd use my weechat module, but I'd much rather reserve some time in the next months to implement it right for upstream :)
Great, thanks for the clarification and you work on this :)
|
Motivation for this change
Contains a packaged version of the LUA script which connects weechat with a matrix server.
I'm currently using it locally and it works fine, however it would be cool if more people could test it :-)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)